Fix accel examples and related CI issues #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
Dec 30, 2024
Test summary 3 935 files 6 063 suites 4m 18s ⏱️ Results for commit acdc79b. ♻️ This comment has been updated with latest results. |
sethrj
changed the title
sethrj
added a commit
to sethrj/celeritas
that referenced
this pull request
Jan 1, 2025
pcanal
reviewed
Jan 1, 2025
sethrj
added a commit
to sethrj/celeritas
that referenced
this pull request
Jan 14, 2025
* Fix typo to enable 'accel' examples * Use debug output for examples * Fix documentation and use uniform distribution * Fix missing error-on-doxygen-warnings on PRs * Specify celeritas build options for documentation * Add documentation about missing SDs * Add example SD to tracking manager offload and fix SD options for others * Fix cmake presets, use cmake build, fix user doc * Add/improve docs for wentzel scattering * Fix doxygen build issues * Fix build-from-install test * Don't check examples because geant4 practices are awful * Disable examples with geant4 nav because accel doesn't support it
sethrj
added a commit
to sethrj/celeritas
that referenced
this pull request
Jan 14, 2025
* Fix typo to enable 'accel' examples * Use debug output for examples * Fix documentation and use uniform distribution * Fix missing error-on-doxygen-warnings on PRs * Specify celeritas build options for documentation * Add documentation about missing SDs * Add example SD to tracking manager offload and fix SD options for others * Fix cmake presets, use cmake build, fix user doc * Add/improve docs for wentzel scattering * Fix doxygen build issues * Fix build-from-install test * Don't check examples because geant4 practices are awful * Disable examples with geant4 nav because accel doesn't support it
sethrj
added a commit
that referenced
this pull request
Jan 14, 2025
* Fix typo to enable 'accel' examples * Use debug output for examples * Fix documentation and use uniform distribution * Fix missing error-on-doxygen-warnings on PRs * Specify celeritas build options for documentation * Add documentation about missing SDs * Add example SD to tracking manager offload and fix SD options for others * Fix cmake presets, use cmake build, fix user doc * Add/improve docs for wentzel scattering * Fix doxygen build issues * Fix build-from-install test * Don't check examples because geant4 practices are awful * Disable examples with geant4 nav because accel doesn't support it
sethrj
added a commit
that referenced
this pull request
Jan 14, 2025
* Fix typo to enable 'accel' examples * Use debug output for examples * Fix documentation and use uniform distribution * Fix missing error-on-doxygen-warnings on PRs * Specify celeritas build options for documentation * Add documentation about missing SDs * Add example SD to tracking manager offload and fix SD options for others * Fix cmake presets, use cmake build, fix user doc * Add/improve docs for wentzel scattering * Fix doxygen build issues * Fix build-from-install test * Don't check examples because geant4 practices are awful * Disable examples with geant4 nav because accel doesn't support it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dumb typo (using a variable name instead of dereferencing the variable name...) meant we weren't testing the
accelexamples in CI. The examples have been failing since at least #1501 . I'm also enabling debug logging so we can figure out initialization ordering for #1556 .An additional error is that "error on doxygen warning" was disabled for PR documentation builds since I changed the name of the workflow in
#1243. This meant a minor documentation error in #1518 was causing issues.